-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ByteBufferPool race condition #5778
Merged
lorban
merged 1 commit into
jetty-9.4.x
from
jetty-9.4.x-5775-ByteBufferPool-timestamp-fix
Dec 9, 2020
Merged
fix ByteBufferPool race condition #5778
lorban
merged 1 commit into
jetty-9.4.x
from
jetty-9.4.x-5775-ByteBufferPool-timestamp-fix
Dec 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
requested changes
Dec 9, 2020
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java
Outdated
Show resolved
Hide resolved
sbordet
requested changes
Dec 9, 2020
jetty-io/src/main/java/org/eclipse/jetty/io/ByteBufferPool.java
Outdated
Show resolved
Hide resolved
sbordet
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion, I think "opaque" semantic is fine for Jetty 10, so please use [get|set]Opaque()
when merging to 10.
…ne in case the timestamp is read while being modified
lorban
force-pushed
the
jetty-9.4.x-5775-ByteBufferPool-timestamp-fix
branch
from
December 9, 2020 15:33
647cae2
to
4151965
Compare
This was referenced Mar 10, 2021
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5775